Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataPipeline setup missing self.setup() #6

Open
bkari2 opened this issue Jun 11, 2024 · 0 comments
Open

DataPipeline setup missing self.setup() #6

bkari2 opened this issue Jun 11, 2024 · 0 comments

Comments

@bkari2
Copy link

bkari2 commented Jun 11, 2024

in flashdiffusion.src.flash.data.datasets.dataset.py

  • DataPipeline init is missing a self.setup() in order to setup properly.

If not done then

data_module.train_pipeline = DataPipeline(
            config=data_module.train_config,
            filters_mappers=data_module.train_filters_mappers,
        )
data_module.train_dataloader()

returns

Cell In[43], [line 145](vscode-notebook-cell:?execution_count=43&line=145)
    [142](vscode-notebook-cell:?execution_count=43&line=142) def dataloader(self):
    [143](vscode-notebook-cell:?execution_count=43&line=143)     # return the loader
    [144](vscode-notebook-cell:?execution_count=43&line=144)     return wds.WebLoader(
--> [145](vscode-notebook-cell:?execution_count=43&line=145)         self.pipeline,
    [146](vscode-notebook-cell:?execution_count=43&line=146)         batch_size=None,
    [147](vscode-notebook-cell:?execution_count=43&line=147)         num_workers=self.config.num_workers,
    [148](vscode-notebook-cell:?execution_count=43&line=148)     )

AttributeError: 'DataPipeline' object has no attribute 'pipeline'
  • Also from webdataset import DataPipeline is unnecessary.

Please let me know if you have a better option.
Otherwise, I am happy to do the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant