Don't look through primitive casts; they actually do change the under…

…lying type! PiperOrigin-RevId: 564691382
google · Sep 13, 2023 · 759c410 · 759c410
1 parent 7552251
commit 759c410
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/...a/com/google/errorprone/bugpatterns/collectionincompatibletype/TruthIncompatibleType.java b/...a/com/google/errorprone/bugpatterns/collectionincompatibletype/TruthIncompatibleType.java
@@ -503,7 +503,7 @@ protected Tree defaultAction(Tree node, Void unused) {
 
           @Override
           public Tree visitTypeCast(TypeCastTree node, Void unused) {
-            return node.getExpression().accept(this, null);
+            return getType(node).isPrimitive() ? node : node.getExpression().accept(this, null);
           }
 
           @Override

diff --git a/...m/google/errorprone/bugpatterns/collectionincompatibletype/TruthIncompatibleTypeTest.java b/...m/google/errorprone/bugpatterns/collectionincompatibletype/TruthIncompatibleTypeTest.java
@@ -571,6 +571,20 @@ public void comparingElementsUsingRawCollection_noFinding() {
         .doTest();
   }
 
+  @Test
+  public void casts() {
+    compilationHelper
+        .addSourceLines(
+            "Test.java",
+            "import static com.google.common.truth.Truth.assertThat;",
+            "public class Test {",
+            "  public void f(int a, long b, long c) {",
+            "    assertThat((long) a).isAnyOf(b, c);",
+            "  }",
+            "}")
+        .doTest();
+  }
+
   @Test
   public void subjectExhaustiveness(
       @TestParameter(valuesProvider = SubjectMethods.class) Method method) {