Make ASTHelpers.getSymbol(Tree) delegate to the MemberReferenceTree overload.
#4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…e` overload. This may or may not actually change behavior: The handling that I added in e5a6d0d was definitely important for `MethodInvocationTree`, since it affects behavior when code uses static imports. However, static imports can't be used with a `MemberReferenceTree`, so the change might not be important there. Still, as I noted in that previous CL's description, I get the impression that this might also help with cases like `someSerializable.equals`—and presumably `someSerializable::equals`, too. Anyway, this change seems clearly like either an improvement in behavior or a no-op that makes the implementation more consistent, so either way feels like a win. PiperOrigin-RevId: 656731744
copybara-service
bot
force-pushed
the
test_654722028
branch
from
3021761
to
9884911
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
ASTHelpers.getSymbol(Tree)delegate to theMemberReferenceTreeoverload.This may or may not actually change behavior: The handling that I added in e5a6d0d was definitely important for
MethodInvocationTree, since it affects behavior when code uses static imports. However, static imports can't be used with aMemberReferenceTree, so the change might not be important there. Still, as I noted in that previous CL's description, I get the impression that this might also help with cases likesomeSerializable.equals—and presumablysomeSerializable::equals, too.Anyway, this change seems clearly like either an improvement in behavior or a no-op that makes the implementation more consistent, so either way feels like a win.