Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cache for Data Layer DataStore #1480

Open
yschimke opened this issue Jul 10, 2023 · 2 comments
Open

Add a cache for Data Layer DataStore #1480

yschimke opened this issue Jul 10, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@yschimke
Copy link
Collaborator

See https://stackoverflow.com/questions/72935096/using-dataclient-getdataitem-as-storage-for-wear-over-datastore

We should also follow this advice and avoid reading directly through to the Data Client.

@yschimke yschimke added the good first issue Good for newcomers label Jul 10, 2023
@yschimke
Copy link
Collaborator Author

yschimke commented Oct 4, 2023

Mainly in DataStore module

https://github.com/google/horologist/blob/main/datalayer/core/src/main/java/com/google/android/horologist/data/store/impl/DataItemFlow.kt

this feature should probably wrap the standard Proto DataStore, but also synchronize the in the background with DataClient.

At the moment, it only reads from DataClient, which effectively means IPC to GMS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant