Improve TokenBundleRepositoryImpl to check if API is available #1089
Conversation
luizgrp
force-pushed
the
authdataphone_improve_tokenbundlerepo
branch
from
c57ca48
to
c002461
Compare
| @@ -75,7 +84,16 @@ class MainActivity : ComponentActivity() { | |||
| modifier = Modifier.fillMaxSize(), | |||
| color = MaterialTheme.colorScheme.background | |||
| ) { | |||
| val coroutineScope = rememberCoroutineScope() | |||
| var apiAvailable by remember { mutableStateOf(false) } | |||
There was a problem hiding this comment.
If it's safe to do the operations, then I think defaulting to true. Or making this true/false/null would be better here. Avoid glitching the screen in the hopefully typical case where it is available.
There was a problem hiding this comment.
it makes sense, and it would be better to have this in a VM, and have proper states
this sample app is very simple, in comparison to the wear counterpart, it's in my plans to improve it further and will address it together
| override suspend fun isAvailable(): Boolean { | ||
| return try { | ||
| GoogleApiAvailability.getInstance() | ||
| .checkApiAvailability(registry.dataClient) |
There was a problem hiding this comment.
Not sure you like the God object of the registry, but if we push this up there, then it can be done once, at startup meaning it's immediately available so screen can draw correctly immediately.
There was a problem hiding this comment.
it would be ideal to have these checks in WearDataLayerRegistry, not sure about having it immediately available, it would be an assumption about the time taken by play service lib to check it
raised #1091
WHAT
Improve
TokenBundleRepositoryImplto check if DataClient API is available.WHY
In order to handle the following exception when device doesn't have the API available:
HOW
DataStoreinTokenBundleRepositoryImpluntilupdatefunction is called;updateto check for api availability and fail silently when not available;isAvailablefunction toTokenBundleRepositoryso developers can check if the repository can be used on the device running;Checklist 馃搵