Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Quality issue with GHSA-w9jx-4g6g-rp7x #2331

Closed
clemens opened this issue Jun 20, 2024 · 1 comment
Closed

Data Quality issue with GHSA-w9jx-4g6g-rp7x #2331

clemens opened this issue Jun 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@clemens
Copy link

clemens commented Jun 20, 2024

Describe the bug
The data for GHSA-w9jx-4g6g-rp7x includes "type": 3 instead of "type": "CVSS_V4".

To Reproduce
Steps to reproduce the behaviour:

  1. curl https://api.osv.dev/v1/vulns/GHSA-w9jx-4g6g-rp7x
  2. Check JSON at the very end

Expected behaviour
I'd expect the response to adhere to declared schema. So in this case it should show "type": "CVSS_V4".

Screenshots
Screenshot 2024-06-20 at 16 56 33

Additional context
I've come across this, because ORT started failing for TinyMCE and traced it back in ORT's code
@abhisek abhisek mentioned this issue Jun 24, 2024
Closed
@hogo6002 hogo6002 added the bug Something isn't working label Jun 25, 2024
@hogo6002 hogo6002 mentioned this issue Jun 25, 2024
Closed
@another-rex another-rex mentioned this issue Jun 25, 2024
Merged
another-rex added a commit that referenced this issue Jun 25, 2024
@another-rex
Attempt at updating the api_descriptor.pb proto (#2342)
e2601cd 
Currently CVSS_4 is not correctly converted to JSON in the API. This is
an attempt at fixing that issue (See #2331)
@michaelkedar
Copy link
Member

michaelkedar commented Jun 25, 2024 •
edited
Loading

The API should now be correctly returning "type": "CVSS_V4" in these cases.

Thanks for reporting this! Let us know if you're still encountering this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clemens @michaelkedar @hogo6002