Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posession of loop() function of the SDK #24

Open
instanceofMA opened this issue Feb 18, 2021 · 0 comments
Open

Posession of loop() function of the SDK #24

instanceofMA opened this issue Feb 18, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@instanceofMA
Copy link
Contributor

The loop function practically runs the SDK and makes the asynchronous behavior possible. User has to call it in the loop() of his/her Arduino sketch. It has nothing to do with a project, it's a function very specific to arduino architecture. Everywhere: on JS SDK and Py SDK, Project class provides access of and methods for interacting with the project space on Grandeur. loop isn't one of those.

My suggestion is, we keep Project, Device, Datastore classes pure and free of the architectural differences and move architecture-specific methods to Grandeur class. User would do grandeur.loop() instead.

@instanceofMA instanceofMA added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Feb 18, 2021
@instanceofMA instanceofMA changed the title Posession of **loop** function of the SDK Posession of loop() function of the SDK Feb 18, 2021
@instanceofMA instanceofMA added enhancement New feature or request good first issue Good for newcomers and removed bug Something isn't working labels Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants