КМБО-03-21 Чертков Глеб #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grayed
requested changes
Jun 6, 2022
|
|
||
|
|
||
| protected: | ||
| Mammal(); |
There was a problem hiding this comment.
Не сделано: конструкторы, сразу инициализирующие поля.
| /// </summary> | ||
| class Object { | ||
| std::string name; | ||
| static Pole* getNewInstance(); |
There was a problem hiding this comment.
Почему не подошёл просто конструктор?
| { | ||
| // TODO | ||
| return false; | ||
| if (_connectedId == pole.getId()) |
There was a problem hiding this comment.
Нет сигнализации об ошибке привязки.
| return _connectedId; | ||
| } | ||
|
|
||
| bool Pole::send(const std::string& command) |
| return nullptr; | ||
| } | ||
|
|
||
| const Pole* Switch::getPole(size_t idx) const | ||
| Pole* Object::getPoleConnectedTo(const Object& object) const |
There was a problem hiding this comment.
Несколько полюсов одного объекта могут быть соединены с несколькими полюсами другого. Простейший пример: батарейка [+] - лампочка - [-] батарейка. Смысл существования данной функции в этом случае не ясен.
| { | ||
| os << "a_s: " << a_s << " b_s: " << getBString() << " data[] = {"; | ||
| for (int i = 0; i < 7; ++i) { | ||
| os << ((float*) ((std::string*) (this + 1) + 1))[i]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Я не очень понял Вашу реализацию electricity, так что вся структура была изменена.
Вкратце об изменениях:
Пример кода:
Вывод:
А еще бонус: пикча с котиком
