Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile only against name fields #228

Closed
acka47 opened this issue Sep 13, 2019 · 3 comments · Fixed by #232
Closed

Reconcile only against name fields #228

acka47 opened this issue Sep 13, 2019 · 3 comments · Fixed by #232
Projects
lobid board

Comments

@acka47
Copy link
Contributor

acka47 commented Sep 13, 2019

Currently, when starting reconciliaton from a row in OpenRefine, a general q query is sent without indicating any specific fields to search. Assuming that reconciliation is per se run on the basis of a text name ("Reconciliation is a semi-automated process of matching text names to database IDs", source), we should limit the request to those fields containing names. These are:

preferredName
variantName
abbreviatedNameForTheConferenceOrEvent
abbreviatedNameForThePlaceOrGeographicName
abbreviatedNameForTheWork
abbreviatedNameForTheCorporateBody
temporaryName

Note: When #227 is done temporaryName will also cover all cases with the more specific properties. I will make an issue in DNB Jira to add a general abbreviatedName property to GNDO.
@acka47 acka47 changed the title Reconcile only against name fields and Reconcile only against name fields Sep 13, 2019
@acka47
Copy link
Contributor Author

acka47 commented Sep 13, 2019 •
edited
Loading

I will make an issue in DNB Jira to add a general abbreviatedName property to GNDO.

I opened an issue at https://jira.dnb.de/browse/GND-112 and will open another issue here opened #229 for using the property instead of the specific properties as soon as it is added.

@acka47 acka47 mentioned this issue Sep 13, 2019
Open
@fsteeg fsteeg added this to Backlog in lobid board via automation Sep 16, 2019
fsteeg added a commit that referenced this issue Sep 16, 2019
@fsteeg
Tweak reconciliation query
a5f3b13 
- Limit main query to name fields
- Boost optional properties query

See #228
@fsteeg
Copy link
Member

fsteeg commented Sep 16, 2019

Deployed to test, reconcile with https://test.lobid.org/gnd/reconcile

See https://refine.graphthinking.com/project?project=2291226341193

@fsteeg fsteeg mentioned this issue Sep 16, 2019
Merged
@fsteeg fsteeg moved this from Backlog to Review in lobid board Sep 16, 2019
@fsteeg fsteeg assigned acka47 and unassigned fsteeg Sep 16, 2019
@acka47
Copy link
Contributor Author

acka47 commented Sep 17, 2019

Just, tested it. This improves reconciliation and automatic matching significantly. 🚀 +1

@acka47 acka47 removed their assignment Sep 17, 2019
@fsteeg fsteeg moved this from Review to Deploy in lobid board Sep 17, 2019
@fsteeg fsteeg closed this as completed in 1de3c12 Sep 17, 2019
lobid board automation moved this from Deploy to Done Sep 17, 2019
@acka47 acka47 mentioned this issue Oct 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
lobid board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tweak reconciliation query hbz/lobid-gnd
2 participants
@fsteeg @acka47