Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integer based representation #140

Open
joamatab opened this issue Jan 4, 2023 · 5 comments
Open

integer based representation #140

joamatab opened this issue Jan 4, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@joamatab
Copy link
Collaborator

joamatab commented Jan 4, 2023

How could we move from floating point to integer based?

GDS database is integer based, and the rounding errors can cause snapping issues.

See how we fix this in gdsfactory

amccaugh/phidl#140

@nmz787-intel
Copy link

I've also been hit with rounding errors and had to questionably resort to fuzzy-matching. It certainly gives me pause about using this vs vendor tools (which have generally terrible APIs/ease-of-use, and I'd prefer to avoid).

@joamatab
Copy link
Collaborator Author

@heitzmann heitzmann added the enhancement New feature or request label Jun 25, 2023
@alibillalhammoud
Copy link

I also ran into significant issues with rounding errors and my project is completely Manhattan routing. I prefer using this tool, but these errors make it difficult. Can we at least get an option for more accurate floats, perhaps use long double by default or a more precise float from the boost library? Although not the robust/performant integer solution, it could at least prevent some of these errors.

@joamatab
Copy link
Collaborator Author

joamatab commented Jul 8, 2023

@sebastian-goeldi
@tvt173

@heitzmann
Copy link
Owner

I also ran into significant issues with rounding errors and my project is completely Manhattan routing. I prefer using this tool, but these errors make it difficult. Can we at least get an option for more accurate floats, perhaps use long double by default or a more precise float from the boost library? Although not the robust/performant integer solution, it could at least prevent some of these errors.

@alibillalhammoud Any chance you can give me an example of error you're facing? Maybe there are strategies to minimize them. As for moving towards integer coordinates, I've been looking into that but it is a very large refactor and I just don't have the time available to do it properly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants