Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add K10+ vaccuum #20

Open
b-0s opened this issue Jun 1, 2024 · 3 comments
Open

Request to add K10+ vaccuum #20

b-0s opened this issue Jun 1, 2024 · 3 comments

Comments

@b-0s
Copy link

b-0s commented Jun 1, 2024

Hello,

Great job done here. A bit scared at first but very easy to install as soon as you understand that you have to install dotnet on your PC before compiling by running the powershell script.
Would you be kind to add the K10+ vaccum model.
I know that it is not referenced yet inthe v1.1 API but it is basically based on the S1 for the commands.
As for the deviceType, it is returnedd simply as K10+.

I have tested it by calling the rest method on thev1.1 API and it works as a charm.

@hsakoh
Copy link
Owner

hsakoh commented Jun 1, 2024

Referring to #10, setting EnforceDeviceTypes may allow the K10+ to be recognized as an S1:

EnforceDeviceTypes:
  - DeviceId: <K10+ DeviceId>
    DeviceType: Robot Vacuum Cleaner S1

In this state, could you please verify if various commands and webhooks operate correctly?

I don't know the K10+ of commands and data items, but if S10 and K10+ have the same, try to set Robot Vacuum Cleaner S10.

The add-on will not be officially supported until the official API specification is released.

@b-0s
Copy link
Author

b-0s commented Jun 1, 2024

Indeed. It works. Wonderful.
Very good job.
But for your information, S1 is much more suited than s10.
With S10, any command that you will try return this message:
{"statusCode":190,"body":{},"message":"Cannot read properties of undefined (reading 'statusCode')"}

S1 is the good to go for the K10+

@hsakoh
Copy link
Owner

hsakoh commented Jun 1, 2024

OpenWonderLabs/SwitchBotAPI#293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants