Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APCu: fix return value of setMultiple() #30

Open
davidrans opened this issue Feb 23, 2021 · 0 comments
Open

APCu: fix return value of setMultiple() #30

davidrans opened this issue Feb 23, 2021 · 0 comments
Labels

Comments

@davidrans
Copy link
Member

Problem

Backend::setMultiple() has a bool return type, but the child class's implementation, APCu::setMultiple(), returns an array. We should address the inconsistency.

Background

https://github.com/iFixit/Matryoshka/blob/master/library/iFixit/Matryoshka/Backend.php#L37
https://github.com/iFixit/Matryoshka/blob/master/library/iFixit/Matryoshka/APCu.php#L16
https://www.php.net/manual/en/function.apcu-store.php#refsect1-function.apcu-store-returnvalues

@davidrans davidrans added the bug label Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant