-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection page review (June 2021) #27
Comments
Wikis API has documents: https://www.ifixit.com/api/2.0/doc/Wikis#content Schematics are not in the API but will be. |
I'm not sure what you mean by this, but Schematics are currently served by the API. They are just not documented. The endpoint is available to the public: https://www.ifixit.com/api/2.0/diagrams/418 |
Sweet! How do you get a list of diagrams for a device? |
CR this pull to find out: https://github.com/iFixit/ifixit/pull/38255 |
Hi @evannoronha, I don't have access to this repo. Can you give me instructions on how to use this endpoint? |
Sure thing! As of right now, I don't think you'll get much use out of it because the set of devices for which we have schematics and parts to sell may be empty. Regardless, here's the basics. We can break this discussion into two bits: data and rendering DataSome of our device pages have schematics on them. For example: On ifixit, we also can link to a specific diagram: Schematics are comprised of 0-n diagrams and an additional list of parts not associated with a diagram. They are represented by the That endpoint should give you enough information to render a summary view of a schematic: Each diagram contains an image and a set of data points that indicate what each component on the diagram is. You can fetch all this information about a diagram from the diagrams endpoint: The diagram endpoint returns JSON that looks like this: That should give you enough information to render a full diagram view: The RenderingOkay, so we have all this great structured data that represents what parts go in which devices. How do we display it all? We built a custom diagram viewer to address this solution. We've been wanting to open source it for a couple months, however the issue to actually make that component available has not been prioritized. We can look at getting that done soon. CC @jarstelfox @MilesRobinson |
Ok then I'll pause this task until we figure out the data side.
Oh wow, this is really cool! 💯 I like the idea, it looks like a great shopping experience too 👍 |
Here's a review of the collection page status:
inkOfPixel todos
Blocked on iFixit
The text was updated successfully, but these errors were encountered: