-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine/fix import/export operations #712
Comments
To properly understand the current situation, I prepared some tables here and proposed handling of invalid situations. @hasanbalci Please check. |
One problem I noticed is the following: Before SBML support, when we try to export SBGN maps as SBML, we were using MINERVA service. After the SBML support, we have write functionality for SBML maps and current 'Export as SBML' button uses that functionality. However, when an SBGN map is open in the canvas and if we try to export the map SBML, the app behaves like the current map is SBML and tries to write it with the write functionality provided with SBML support. Instead it should use Minerva converter instead to convert the current SBGN map to SBML. |
After having discussed all varying combinations, here is what needs to change according to this document (same numbering used in the document):
|
…t imports. Item 2: Using Minerva when converting SBML to .sbgnml
Regarding item 3, I pushed some fixes to sbgnviz for the SBML map to .sbml export. iVis-at-Bilkent/sbgnviz.js@2cc6ec6 |
Current export menu is implemented for exporting SBGNML maps to other formats such as SBML, SIF etc. and they should be working well. However, when we added other formats, SIF and SBML, we didn't put any restrictions for users to use export functionality for these types and this currently leads to wrong export operations. For example, user is able to export SBML file to SBGNML but not in the proper way. The output file of this conversion leads to an SBGNML file with map type SBML which is inconvenient. As a solution we need to add support for possible conversions and disable the rest with a warning message.
Minerva converter that we are currently using for some format conversions supports conversion of SBML to SBGN, GPML and CellDesigner. So we can add support for these three conversions (For SBML -> SBGN conversion, we need to check to which SBGNML version Minerva converts). I think, SBML to SIF conversion can be implemented manually.
Other conversions, SIF to all other formats and if there is any from SBML, we need to show a warning to the user that the export is not currently possible.
The text was updated successfully, but these errors were encountered: