Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReciprocatingWaterToWater and ScrollWaterToWater only allow one stage #1727

Open
mwetter opened this issue Apr 15, 2023 · 0 comments
Open

ReciprocatingWaterToWater and ScrollWaterToWater only allow one stage #1727

mwetter opened this issue Apr 15, 2023 · 0 comments
Assignees

Comments

@mwetter
Copy link
Contributor

mwetter commented Apr 15, 2023

The heat pump models ReciprocatingWaterToWater and ScrollWaterToWater allow for a continuous input signal y and an integer input signal stage.

However, if stage is used, it is internally limited to be between 0 and 1. This is in PartialWaterToWater:

protected 
  Modelica.Blocks.Math.IntegerToReal intToRea
 if enable_variable_speed == false "Conversion for stage signal"
    annotation (Placement(transformation(extent={{-80,-40},{-60,-20}})));

  Modelica.Blocks.Nonlinear.Limiter lim(final uMin=0, final uMax=1)
 if enable_variable_speed == false "Limiter for control signal"
    annotation (Placement(transformation(extent={{-50,-40},{-30,-20}})));

Thus, users can only set stage = 0 or stage = 1, any other value will be set to one of these two. This is consistent with the compressor model which requires an input between 0 and 1.

Also, the model has only one compressor characteristic (as opposed to some DX coils in Buildings that have different performance characteristics for different stages).

Therefore, as stage only allows essentially on or off, I suggest to remove the option of an integer input signal. If users want to model discrete stages, they could do so by feeding only discrete values of y to the model.

@MassimoCimmino : What do you think about this change which is in response to a user inquiry about how to use stages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants