Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #3

Open
wangcj05 opened this issue Nov 8, 2023 · 0 comments
Open

Improvements #3

wangcj05 opened this issue Nov 8, 2023 · 0 comments

Comments

@wangcj05
Copy link
Collaborator

wangcj05 commented Nov 8, 2023

  • Unfortunately the "compute Covariance" does not work.... it returns all NaN... I had to input the diagonal covariance by hand.
  • RavenRunningRaven does not work as well because the output of the inner is not interpreted as an HistorySet but as pointSet (no matter what I do in the outer dataobject). I had to use the GenericCode interface for the inner
  • The node if does not have the simply silently "skips" the reduction (Without informing the user)
  • If the is inputted and == 0 (optimal rank should be computed atuomatically) the reduction is skipped because this line "if self._subspace is None and self._truncationRank:" is evaluated as False (since if "self._truncationRank is 0.0 and it is False)...It should be modified to "if self._subspace is None and self._truncationRank is not None"
  • If the is set to > 1 the code just crashes after the first evaluation.
  • It would be nice to have the possibility to provide the values as CSV (or RAVEN data object) and maybe also to associate a pivot parameter to them (so the underlying model can be run in parallel (e.g. the inner RAVEN that runs relap5 for each experiement). Now I am forced to have the inner to run in serial to keep the right order of values (mapping with the values in )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant