-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added code coverage tracking to github action #378
Open
caleb-sitton-inl
wants to merge
9
commits into
idaholab:devel
Choose a base branch
from
caleb-sitton-inl:coverage-github-action
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
71614bd
Added code coverage tracking to github action
caleb-sitton-inl ce3d555
Reworked total coverage report generation
caleb-sitton-inl 96f3b1a
Added script to enable simple coverage report from github action
caleb-sitton-inl 9c6bc7f
Debugging coverage scripts
caleb-sitton-inl 9df92e4
Edits to coverage reporting structure and created directory
caleb-sitton-inl 9c8feba
Fixing bug
caleb-sitton-inl 1fed821
Additional debugging
caleb-sitton-inl f2a5787
Taking care of one more bug
caleb-sitton-inl c543d79
Addressing comments
caleb-sitton-inl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
#!/bin/bash | ||
SCRIPT_DIRNAME=`dirname $0` | ||
HERON_DIR=`(cd $SCRIPT_DIRNAME/..; pwd)` | ||
cd $HERON_DIR | ||
RAVEN_DIR=`python -c 'from src._utils import get_raven_loc; print(get_raven_loc())'` | ||
|
||
source $HERON_DIR/coverage_scripts/initialize_coverage.sh | ||
|
||
#coverage help run | ||
SRC_DIR=`(cd src && pwd)` | ||
|
||
export COVERAGE_RCFILE="$SRC_DIR/../coverage_scripts/.coveragerc" | ||
SOURCE_DIRS=($SRC_DIR,$SRC_DIR/../templates/) | ||
OMIT_FILES=($SRC_DIR/dispatch/twin_pyomo_test.py,$SRC_DIR/dispatch/twin_pyomo_test_rte.py,$SRC_DIR/dispatch/twin_pyomo_limited_ramp.py,$SRC_DIR/ArmaBypass.py) | ||
EXTRA="--source=${SOURCE_DIRS[@]} --omit=${OMIT_FILES[@]} --parallel-mode " | ||
export COVERAGE_FILE=`pwd`/.coverage | ||
|
||
coverage erase | ||
($RAVEN_DIR/run_tests "$@" --re=HERON/tests --python-command="coverage run $EXTRA " || echo run_tests done but some tests failed) | ||
|
||
## Prepare data and generate the html documents | ||
coverage combine | ||
coverage html | ||
|
||
# See report_py_coverage.sh file for explanation of script separation | ||
(bash $HERON_DIR/coverage_scripts/report_py_coverage.sh --data-file=$COVERAGE_FILE --coverage-rc-file=$COVERAGE_RCFILE) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
#!/bin/bash | ||
|
||
# To be run after a run of check_py_coverage.sh | ||
# This script has been separated from check_py_coverage.sh for the github action, so that | ||
# the output of run_tests within check_py_coverage.sh can be printed, but the report | ||
# value can be caught and put in an annotation. This is necessary because calling | ||
# "coverage report --format=total" directly in the yaml does not work | ||
|
||
SCRIPT_DIRNAME=`dirname $0` | ||
HERON_DIR=`(cd $SCRIPT_DIRNAME/..; pwd)` | ||
cd $HERON_DIR | ||
|
||
source coverage_scripts/initialize_coverage.sh > /dev/null 2>&1 | ||
|
||
# read command-line arguments | ||
ARGS=() | ||
for A in "$@" | ||
do | ||
case $A in | ||
--data-file=*) | ||
export COVERAGE_FILE="${A#--data-file=}" # Removes "--data-file=" and puts path into env variable | ||
;; | ||
--coverage-rc-file=*) | ||
export COVERAGE_RCFILE="${A#--coverage-rc-file=}" # See above | ||
;; | ||
*) | ||
ARGS+=("$A") | ||
;; | ||
esac | ||
done | ||
|
||
COV_VAL=`coverage report --format=total "${ARGS[@]}"` | ||
if [[ $COV_VAL = "No data to report." ]] | ||
then | ||
echo "Could not find data file with coverage results." | ||
exit 0 | ||
fi | ||
|
||
echo "Coverage for this repository is now $COV_VAL%." |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to confirm -- this doesn't change any functionality, it just cleans up the reporting? since there are no tests run outside of the
HERON/tests
directory?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, because of some strange paths in the github runner, with the previous version all plugin tests for HERON, TEAL, and the ExamplePlugin were being run. This limits it to only the HERON tests.