Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEFECT] TEAL CashFlow standalone does not work #79

Closed
5 of 10 tasks
alfoa opened this issue Dec 1, 2023 · 2 comments · Fixed by #80
Closed
5 of 10 tasks

[DEFECT] TEAL CashFlow standalone does not work #79

alfoa opened this issue Dec 1, 2023 · 2 comments · Fixed by #80
Assignees
Labels
defect Something isn't working priority-critical

Comments

@alfoa
Copy link
Collaborator

alfoa commented Dec 1, 2023


Defect Description

Describe the defect

What did you expect to see happen?

That the CashFlow standalone could be used.

I cannot use TEAL as "Plugin/external model" because I need to sample/modify variables in the Cash flow input files (not accessible through RAVEN external model interface)

What did you see instead?

Running the command python ./raven/plugins/TEAL/src/CashFlow_ExtMod.py -h as indicated in the manual does not work. It crashes with an error:

Traceback (most recent call last):
  File "./raven/plugins/TEAL/src/CashFlow_ExtMod.py", line 27, in <module>
    import main
  File "./raven/plugins/TEAL/src/main.py", line 28, in <module>
    from ..src import CashFlows
ImportError: attempted relative import with no known parent package
Do you have a suggested fix for the development team?

a driver is needed

Describe how to Reproduce
Steps to reproduce the behavior:

  1. see above

Screenshots and Input Files
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

Platform (please complete the following information):

  • OS: [e.g. iOS]
  • Version: [e.g. 22]
  • Dependencies Installation: [CONDA or PIP]

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@alfoa alfoa added the defect Something isn't working label Dec 1, 2023
@alfoa
Copy link
Collaborator Author

alfoa commented Dec 1, 2023

@worseliz @dylanjm @wangcj05

@alfoa alfoa mentioned this issue Dec 4, 2023
9 tasks
alfoa added a commit that referenced this issue Dec 4, 2023
@dylanjm
Copy link
Collaborator

dylanjm commented Dec 4, 2023

Approved to close via #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working priority-critical
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants