Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional LAMMPS dependency #349

Open
dschwen opened this issue Aug 23, 2018 · 0 comments
Open

Add optional LAMMPS dependency #349

dschwen opened this issue Aug 23, 2018 · 0 comments
Assignees

Comments

@dschwen
Copy link
Member

dschwen commented Aug 23, 2018

Let's figure out what the best way for coupling LAMMPS into Magpie is. Should we

a) add a LAMMPS submodule, like we're doing with SPPARKS? This will not work yet, as LAMMPS will not build with the strict compiler flags MOOSE is setting.
b) use LAMMPS as a library (we can use extract_fix to get pointers to internal lammps objects). This will make it harder to add custom LAMMPS objects (which we could have in the Magpie source tree otherwise). Basically users will have compile lammps with a custom add-on package (module).

@dschwen dschwen self-assigned this Aug 23, 2018
dschwen added a commit to dschwen/magpie that referenced this issue Aug 23, 2018
dschwen added a commit to dschwen/magpie that referenced this issue Aug 23, 2018
dschwen added a commit to dschwen/magpie that referenced this issue Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant