Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Code Coverage for former Baldr objects #28

Open
moosebuild opened this issue Dec 24, 2021 · 1 comment
Open

Improve Code Coverage for former Baldr objects #28

moosebuild opened this issue Dec 24, 2021 · 1 comment
Labels
c: infrastructure p: normal t: task Label for general tasks

Comments

@moosebuild
Copy link

In GitLab by @cticenhour on Dec 23, 2021, 23:06

Reason

Test coverage in MALAMUTE could be improved.

Design

Look at https://malamute-dev.hpc.inl.gov/coverage/

Former Baldr objects added in !6 are not tested fully because their tests were skipped. These tests should be fixed.

Impact

Better test coverage.
@moosebuild
Copy link
Author

In GitLab by @cticenhour on Jan 4, 2022, 13:53

mentioned in commit 7c1dc16

sapitts pushed a commit to sapitts/malamute that referenced this issue Mar 9, 2023
@cticenhour
Lower coverage requirement to 65%
d9422f5 
The legacy params check in MOOSE (recently removed) was artificially inflating the MALAMUTE coverage level, as Baldr objects were untested but hit by the params check action anyway during MOOSE operation.

Refs idaholab#28
@cticenhour cticenhour mentioned this issue May 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: infrastructure p: normal t: task Label for general tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moosebuild