Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small diffs on VTR model #265

Open
2 of 3 tasks
GiudGiud opened this issue Aug 13, 2023 · 0 comments
Open
2 of 3 tasks

Small diffs on VTR model #265

GiudGiud opened this issue Aug 13, 2023 · 0 comments
Labels
bug Something isn't working model_maintenance Removing deprecation, adapting to new techniques for performance or usability

Comments

@GiudGiud
Copy link
Collaborator

GiudGiud commented Aug 13, 2023 •
edited
Loading

The VTR full core model has started diffing at the 4e-5 relative difference level.
See the submodule udpate in #260

The VTR assembly has started diffing with merging #194 seemingly, also with a submodule update

We should:

  • identify which part of the solve has started diffing
  • see if re-golding is appropriate with SMEs
  • if not, take corrective action
@GiudGiud GiudGiud added the bug Something isn't working label Aug 13, 2023
@GiudGiud GiudGiud added repo_maintenance Fixing broken links, reorganizing documentation model_maintenance Removing deprecation, adapting to new techniques for performance or usability and removed repo_maintenance Fixing broken links, reorganizing documentation labels Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working model_maintenance Removing deprecation, adapting to new techniques for performance or usability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GiudGiud