Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAM - BC diff on msr/msfr/plant/steady TH input #408

Open
GiudGiud opened this issue Jul 17, 2024 · 0 comments
Open

SAM - BC diff on msr/msfr/plant/steady TH input #408

GiudGiud opened this issue Jul 17, 2024 · 0 comments
Labels
bug Something isn't working reactor_msr Tied to Molten Salt Reactor modeling

Comments

@GiudGiud
Copy link
Collaborator

Bug Description

1st time step fails with BC, not with SAM

Steps to Reproduce

Run that input with recent BC and recent SAM, watch the first time step act differently

Impact

annoying for CI more than anything
The time steps taken are different but that does not necessarily make the results meaningfully different
@GiudGiud GiudGiud added bug Something isn't working reactor_msr Tied to Molten Salt Reactor modeling labels Jul 17, 2024
GiudGiud added a commit to joshuahansel/virtual_test_bed that referenced this issue Jul 17, 2024
@GiudGiud
Address test failures
f56c87b 
- increase max_time on a slow test
- restrict BC away from a test where it disagrees with SAM refs idaholab#408
GiudGiud added a commit to joshuahansel/virtual_test_bed that referenced this issue Jul 17, 2024
@GiudGiud
Address test failures
92e3060 
- increase max_time on a slow test
- restrict BC away from a test where it disagrees with SAM refs idaholab#408
- restrict moose away from a test where it passes the time step that BC / Pgh fail
We will likely remove the v |v| friction treatment and both will be consistent again
GiudGiud added a commit to joshuahansel/virtual_test_bed that referenced this issue Jul 18, 2024
@GiudGiud
Address test failures
fe1f8f1 
- increase max_time on a slow test
- restrict BC away from a test where it disagrees with SAM refs idaholab#408
- restrict moose away from a test where it passes the time step that BC / Pgh fail
We will likely remove the v |v| friction treatment and both will be consistent again
- loosen tolerances on other affected MSFR tests from this friction model change
- remove devel testing until getter simple issue is fixed
GiudGiud added a commit to joshuahansel/virtual_test_bed that referenced this issue Jul 18, 2024
@GiudGiud
Address test failures
ee8e86d 
- increase max_time on a slow test
- restrict BC away from a test where it disagrees with SAM refs idaholab#408
- restrict moose away from a test where it passes the time step that BC / Pgh fail
We will likely remove the v |v| friction treatment and both will be consistent again
- loosen tolerances on other affected MSFR tests from this friction model change
- remove devel testing until getter simple issue is fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working reactor_msr Tied to Molten Salt Reactor modeling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GiudGiud