Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Changing on Dependencies #4

Closed
wants to merge 8 commits into from
Closed

Update: Changing on Dependencies #4

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
47e9170
chore: update dependencies version
UtkuErdemir Dec 31, 2023
26037a2
Merge branch 'main' of https://github.com/UtkuErdemir/ikari
UtkuErdemir Dec 31, 2023
25cf4ed
Merge branch 'ikari-js:main' into main
UtkuErdemir Dec 31, 2023
d5e3b91
fix: changed type
UtkuErdemir Dec 31, 2023
5dc2158
fix: removed toJSON
UtkuErdemir Dec 31, 2023
aab56c8
Merge branch 'main' of https://github.com/UtkuErdemir/ikari
UtkuErdemir Dec 31, 2023
4d02acf
refactor: added toJSON back
UtkuErdemir Dec 31, 2023
c2659ac
fix: revert back update
UtkuErdemir Dec 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion __test__/ikari.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3464,7 +3464,7 @@ const createContextMock = (method: HttpMethod) => {
const statusMock = jest.fn();
const jsonMock = jest.fn();
const getResWithoutBodyMock = jest.fn();
const resMock = {};
const resMock = {} as Response;
const context = {
method,
status: (param: number) => {
Expand Down
Binary file modified bun.lockb
100644 → 100755
View file
Open in desktop
Binary file not shown.
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@
},
"license": "MIT",
"devDependencies": {
"@typescript-eslint/eslint-plugin": "^6.11.0",
"@typescript-eslint/parser": "^6.11.0",
"bun-types": "latest",
"eslint": "^8.53.0",
"@typescript-eslint/eslint-plugin": "^6.16.0",
"@typescript-eslint/parser": "^6.16.0",
"bun-types": "^1.0.20",
"eslint": "^8.55.0",
"eslint-plugin-import": "^2.29.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we are changing dependencies is there any specific reason

Copy link
Contributor Author

@UtkuErdemir UtkuErdemir Dec 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just staying up to date. When we run bun update, it updates directly. Just i have removed latest tag from there because in the future it may create an issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess latest can be stay for bun-types

},
"peerDependencies": {
Expand All @@ -63,6 +63,6 @@
"dependencies": {
"fast-querystring": "^1.1.2",
"radix3": "^1.1.0",
"reflect-metadata": "^0.1.13"
"reflect-metadata": "^0.2.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we are changing dependencies is there any specific reason

}
}
12 changes: 6 additions & 6 deletions src/context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ export class Context {
this.res = new Response(null, {
status: status,
headers: {
...this.res.headers.toJSON(),
...Object.fromEntries(this.res.headers),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toJSON() in bun about 10x faster than Object.fromEntries(headers.entries())

Copy link
Contributor Author

@UtkuErdemir UtkuErdemir Dec 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be, but that usage fails pipeline for TS checking. I didn't prefer that, i have changed when pipeline was failed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting should't be fail can you rollback toJSON and retry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added back and pipeline is failed again. Could you look that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just rollback all toJSON i can force pipeline it should't be fail

},
});

Expand Down Expand Up @@ -321,7 +321,7 @@ export class Context {
this.res = new Response(jsonData, {
status: status || this.res.status,
headers: {
...this.res.headers.toJSON(),
...Object.fromEntries(this.res.headers),
"Content-Type": "application/json",
Comment on lines -324 to 325
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same above

},
});
Expand Down Expand Up @@ -371,7 +371,7 @@ export class Context {
public getResWithoutBody(): Response {
return new Response(null, {
status: this.res.status,
headers: this.res.headers,
headers: Object.fromEntries(this.res.headers),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same above

});
}

Expand Down Expand Up @@ -400,7 +400,7 @@ export class Context {
this.res = new Response(data, {
status: status || this.res.status,
headers: {
...this.res.headers.toJSON(),
...Object.fromEntries(this.res.headers),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same above

"Content-Type": contentType,
},
});
Expand All @@ -426,7 +426,7 @@ export class Context {
this.res = new Response(data, {
status: status || this.res.status,
headers: {
...this.res.headers.toJSON(),
...Object.fromEntries(this.res.headers),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same above

"Content-Type": contentType,
},
});
Expand All @@ -452,7 +452,7 @@ export class Context {
this.res = new Response(data, {
status: status || this.res.status,
headers: {
...this.res.headers.toJSON(),
...Object.fromEntries(this.res.headers),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same above

"Content-Type": contentType,
},
});
Expand Down