Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External CSS and JS loaded over HTTP instead of HTTPS #30

Open
command-tab opened this issue Oct 10, 2016 · 1 comment
Open

External CSS and JS loaded over HTTP instead of HTTPS #30

command-tab opened this issue Oct 10, 2016 · 1 comment

Comments

@command-tab
Copy link

command-tab commented Oct 10, 2016

While running Safari Technology Preview 14 on OS X El Capitan 10.11.6, sqltap loads several external CSS and JavaScript resources over HTTP instead of HTTPS. When the instrumented web app is running over HTTPS, the non-HTTPS resources requested by sqltap are refused by the browser:

https

Would it be possible to make external resources always load over HTTPS, or ship them within sqltap?

Thanks so much for making such a great tool. It's one of my go-to debugging tricks!

Update: Chrome 53 behaves in the same way, but additionally reports that sqltap is insecurely loading the parent site's favicon.

@inconshreveable
Copy link
Owner

Happy to take a PR for this, it seems like a great idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants