Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computation of sigma in ITU-R P.1853 #77

Open
esqt opened this issue Apr 21, 2023 · 0 comments
Open

Computation of sigma in ITU-R P.1853 #77

esqt opened this issue Apr 21, 2023 · 0 comments

Comments

@esqt
Copy link

esqt commented Apr 21, 2023

Hello,

I might be wrong on this one, but it seems to me that your implementation of step A3 of ITU-R P.1853-1 is not exactly correct: it is using the inverse of the CDF of the normal distribution (ppf), instead of the Q function. This results in a negative sigma, which is by definition impossible.

Q = stats.norm.ppf((Pi / 100))

If I'm not mistaken, this should be easily fixed by adding a minus sign in front of stats.norm.ppf for steps A3 and C1.

Anyways, thanks for the excellent work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant