-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLVM-12 compilation error #57
Comments
Thanks for reporting! I will look into that but don't promise it will be soon enough. Looks like your change makes the trick indeed, but need to check it. |
by reading some doc I realized it would be better to remove gnu__inline instead |
@sherpya : Would you like me to amend the PR to do this? |
@r-barnes a PR would be simple, we just need to decide, I've found this discussion so far: |
Hi @Zvictoria @sherpya @r-barnes. Any conclusion so far for this? Still happens with |
Hi, @yairfine On my OS (Windows :) ) LLVM 12.0 compiler everything fine as is. I've done some simple tests on Ubuntu 20.4- looks like removing gnu_inline is fine, so do you have any other LLVM versions tests? |
@Zvictoria Thank you for your reply! removing |
@yairfine while I have no clue on why it happens in LLVM12, if it really removes inlining (it might not however :) then if influence performance negatively indeed - I've seen the cases with up to 5% loss. So I'd prefer not to upstream it for now. Good it solves the problem for you however. |
When compiling with LLVM-12, I see:
Switching
to
appears to solve the problem, but I don't know if this is the best approach.
The text was updated successfully, but these errors were encountered: