feat: update repo to use flat config && update integration tests #22
Conversation
|
|
@ota-meshi I'm having issues with the Integration tests working on CI. I got them to work locally using the ESLint class method, but that failed when I pushed to CI. Then I switched to using the execySync node process (mostly copied from the vue eslint plugin) in this commit but that failed locally and also on CI. Do you know what the issue might be? |
|
Wow! Thank you for this PR! I haven't run it so I don't know, but we might need the |
|
Ah, I think it's because the - env: { ESLINT_USE_FLAT_CONFIG: 'false' }
+ env: { ...process.env, ESLINT_USE_FLAT_CONFIG: 'false' } |
|
@ota-meshi Thank you, I've made the update. The CI still fails for both flat and legacy config but with different errors this time EDIT: The Legacy config test works now. Debugging the issue with the flat config now |
| parser: svelteParser | ||
| }, | ||
| rules: { | ||
| '@intlify/svelte/no-raw-text': 'error' |
There was a problem hiding this comment.
We probably need to remove this. The rule needs to be flagged with a warning, otherwise execSync will throw an error.
Or we need to gather the reports in another way that doesn't use execSync.
There was a problem hiding this comment.
Okay, so I'll update the code to work with the first option
There was a problem hiding this comment.
It worked locally but failed on the CI
There was a problem hiding this comment.
Just tried the second options. Also fails on CI
There was a problem hiding this comment.
It worked locally but failed on the CI
I think it's failing with yarn install, it seems like it needs to install ignoring dependency version compatibility.
There was a problem hiding this comment.
Ah, it works! Thanks a lot @ota-meshi
This PR adds support for ESLint V9 Flat config and also updates the
/integration-teststo support bothflat-configandlegacy-config.