Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo spaghettification of #hal.device.* attrs and analysis. #17694

Open
benvanik opened this issue Jun 18, 2024 · 0 comments
Open

Undo spaghettification of #hal.device.* attrs and analysis. #17694

benvanik opened this issue Jun 18, 2024 · 0 comments
Assignees
Labels
compiler/dialects Relating to the IREE compiler dialects (flow, hal, vm)

Comments

@benvanik
Copy link
Collaborator

HAL devices have made their way into the flow and stream dialects in unfortunate ways. In most cases it's just the IREE::HAL::DeviceAnalysis that is required for resolving information about affinities such that queryBufferCompatibility, hackier passes like CPUMaterializeEncodingsPass, and others can ask some basic questions about resources with differing affinities. It'd be good to add attr interfaces or extend the current ones in ways to resolve this information locally where possible, and short of that potentially a dialect interface for pulling in abstract analysis information that can be used to hide the dialect types. I've given up for now but if we want to target anything other than the HAL dialect or support wrapped affinities we'll need to decouple the analysis.

@benvanik benvanik added the compiler/dialects Relating to the IREE compiler dialects (flow, hal, vm) label Jun 18, 2024
@benvanik benvanik self-assigned this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/dialects Relating to the IREE compiler dialects (flow, hal, vm)
Projects
None yet
Development

No branches or pull requests

1 participant