Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert keystone support in v3 or merge keystone support in iron_core_php #43

Closed
mike182uk opened this issue Feb 5, 2015 · 0 comments
Closed

Comments

@mike182uk
Copy link

Hey,

I'm getting Notice: Undefined property: IronMQ::$use_keystone when using the v3 branch.

The reason i'm getting this error is because iron-io/iron_core_php#12 has not been merged but #38 has been merged. IMO both of these PR's should of been merged at the same time as they are dealing with the same bit of functionality.

I noticed a fix for this was recently merged (#42) but i don't think this is the correct way to handle the problem. When iron-io/iron_core_php#12 finally gets merged there is going to be a redundant isset($this->use_keystone) which will most likely get forgot about and left in.

A better approach may be to either get iron-io/iron_core_php#12 merged and revert #42 or revert #38 and #42 until iron-io/iron_core_php#12 can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant