Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash-build.js ignores errors generated by build command #649

Open
kbrownlees opened this issue Dec 10, 2019 · 1 comment
Open

bash-build.js ignores errors generated by build command #649

kbrownlees opened this issue Dec 10, 2019 · 1 comment

Comments

@kbrownlees
Copy link

Just had a case where my webpack build was failing, but it got ignored so it appeared that the build works fine until you load it onto a device. At which point the bundle does not exist and it hangs.

IMO bash-build should explode if the build command returns a non 0 exit code? Or at least it should be configurable from your framework definition.

@alexblom
Copy link
Member

Thanks for the report - I've managed to replicate now. I agree it should blow up. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants