Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for margins on generated images #8

Open
jackwilsdon opened this issue Oct 24, 2018 · 0 comments
Open

Add support for margins on generated images #8

jackwilsdon opened this issue Oct 24, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@jackwilsdon
Copy link
Owner

jackwilsdon commented Oct 24, 2018

It'd be nice to have this as the default - maybe generating images with a "1 block" margin like so (1px border added to clarify margin);

Example image

This does raise the issue of "how do we scale images" now, as currently if you ask for a 512x512 image then we draw blocks of (512/8)x(512/8), which wouldn't be possible if a margin is added.


Alternatively we could discard the outer 1 block border like so, which does avoid the issue of scaling;

Example image #2

The issue now is that we've discarded over 40% of the source image by removing the surrounding 28 blocks! 😱

@jackwilsdon jackwilsdon added the enhancement New feature or request label Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant