Skip to content

Commit

Permalink
Fix
Browse files Browse the repository at this point in the history
Signed-off-by: Pavol Loffay <[email protected]>
  • Loading branch information
pavolloffay committed Jul 3, 2024
1 parent 0f6bc35 commit f5f0d17
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 6 deletions.
File renamed without changes.
2 changes: 1 addition & 1 deletion plugin/storage/es/mappings/mapping.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func (mb *MappingBuilder) GetMapping(mapping string) (string, error) {
} else if mb.EsVersion == 7 {
return mb.fixMapping(mapping + "-7.json")
}
return mb.fixMapping(mapping + ".json")
return mb.fixMapping(mapping + "-6.json")
}

// GetSpanServiceMappings returns span and service mappings
Expand Down
6 changes: 3 additions & 3 deletions plugin/storage/es/mappings/mapping_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,13 @@ func TestMappingBuilder_loadMapping(t *testing.T) {
tests := []struct {
name string
}{
{name: "jaeger-span.json"},
{name: "jaeger-span-6.json"},
{name: "jaeger-span-7.json"},
{name: "jaeger-span-8.json"},
{name: "jaeger-service.json"},
{name: "jaeger-service-6.json"},
{name: "jaeger-service-7.json"},
{name: "jaeger-service-8.json"},
{name: "jaeger-dependencies.json"},
{name: "jaeger-dependencies-6.json"},
{name: "jaeger-dependencies-7.json"},
{name: "jaeger-dependencies-8.json"},
}
Expand Down
9 changes: 8 additions & 1 deletion plugin/storage/integration/elasticsearch_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,14 @@ func TestElasticsearchStorage_IndexTemplates(t *testing.T) {
esVersion, err := s.getVersion()
require.NoError(t, err)
// TODO abstract this into pkg/es/client.IndexManagementLifecycleAPI
if esVersion == 7 {
if esVersion == 6 {

Check failure on line 204 in plugin/storage/integration/elasticsearch_test.go

View workflow job for this annotation

GitHub Actions / lint

ifElseChain: rewrite if-else to switch statement (gocritic)
serviceTemplateExists, err := s.client.IndexTemplateExists(indexPrefix + "-jaeger-service").Do(context.Background())
require.NoError(t, err)
assert.True(t, serviceTemplateExists)
spanTemplateExists, err := s.client.IndexTemplateExists(indexPrefix + "-jaeger-span").Do(context.Background())
require.NoError(t, err)
assert.True(t, spanTemplateExists)
} else if esVersion == 7 {
serviceTemplateExists, err := s.client.IndexTemplateExists(indexPrefix + "-jaeger-service").Do(context.Background())
require.NoError(t, err)
assert.True(t, serviceTemplateExists)
Expand Down
2 changes: 1 addition & 1 deletion plugin/storage/integration/es_index_cleaner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const (
spanIndexName = "jaeger-span-2019-01-01"
serviceIndexName = "jaeger-service-2019-01-01"
indexCleanerImage = "jaegertracing/jaeger-es-index-cleaner:latest"
rolloverImage = "jaegertracing/jaeger-es-rollover:latest"
rolloverImage = "pavolloffay/jaeger-es-rollover:PR5704"
rolloverNowEnvVar = `CONDITIONS='{"max_age":"0s"}'`
)

Expand Down

0 comments on commit f5f0d17

Please sign in to comment.