Added LCS implementation in Ruby (#2252) #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jainaman224 I have implemented LCS algorithm in Ruby. Please review the changes and let me know if I need to add/change something. Thank You |
singh-shreya6
requested changes
Apr 23, 2020
| end | ||
|
|
||
| # Driver Code | ||
| arr1 = [10, 15, 20, 25, 30, 35, 40] |
There was a problem hiding this comment.
It is possible to take dynamic inputs in Ruby. Please update the code to take dynamic inputs. This requirement is only relaxed for languages like js or php where we have to create forms for dynamic inputs.
There was a problem hiding this comment.
Have changed to dynamic input
| # The longest common subsequence comprises of elements 10, 25, 30, 40 in the above arrays | ||
| # Output: | ||
| # Length of Longest Common Subsequence is: 4 | ||
| puts "Length of Longest Common Subsequence is: #{len}" |
There was a problem hiding this comment.
Please add a blank line at end of file
| @@ -0,0 +1,40 @@ | |||
| # Problem Statement- Given two sequences, find | |||
There was a problem hiding this comment.
Please convert these to a single multi line comment.
There was a problem hiding this comment.
Converted them to a single multi-line comment
Tahanima
force-pushed
the
feature/lcs_in_ruby
branch
from
28509d2
to
ac37213
Compare
singh-shreya6
requested changes
Apr 24, 2020
Tahanima
force-pushed
the
feature/lcs_in_ruby
branch
from
439e775
to
242aa75
Compare
singh-shreya6
approved these changes
Apr 25, 2020
Amitsharma45
pushed a commit
to Amitsharma45/Algo_Ds_Notes
that referenced
this pull request
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2252
Checklist:
Changes proposed in this pull request:
Languages Used:
Files Added:
Thanks!