Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star ratings do not respond to tab inputs #59

Open
verhey opened this issue May 18, 2017 · 3 comments
Open

Star ratings do not respond to tab inputs #59

verhey opened this issue May 18, 2017 · 3 comments

Comments

@verhey
Copy link

verhey commented May 18, 2017

Star ratings do not respond to tab inputs, rendering the output inaccessible for those with mobility disabilities/those that have trouble using a mouse.

@mikeploeger
Copy link

Just add "tabindex" to each star field fixes this.

@mikeploeger
Copy link

Heres the full code:

// Render rating icons for (var i = options.min; i <= options.max; i++) { $ratingEl.append('<i class="' + options.iconLib + '" data-value="' + i + '" tabindex="0"></i>'); }

@javiertoledo
Copy link
Owner

Thanks for the tip, PRs are appreciated! :-D

I'll eventually fix that if I find the time, but sending a PR will speed up the process..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants