Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlights don't work #202

Open
Hirashi3630 opened this issue Oct 20, 2022 Discussed in #196 · 5 comments · Fixed by antoKeinanen/obsidian-sanctum-reborn#9
Open

Highlights don't work #202

Hirashi3630 opened this issue Oct 20, 2022 Discussed in #196 · 5 comments · Fixed by antoKeinanen/obsidian-sanctum-reborn#9

Comments

@Hirashi3630
Copy link

Hirashi3630 commented Oct 20, 2022

It has been 2 weeks since I posted this as a discussion and no one answered, so I'm trying this here because I'd love to use this feature!

Discussed in #196

Originally posted by Hirashi3630 October 6, 2022
Hi, I can't find anyone asking this before, so here I go.

In the wiki, it's shown that highlights display as an underline + animated on hover

working multicolored highlights

mine looks like this (static)

mine multicolored highlights

Is this something I need to turn on?

I've searched in Style Settings plugin and found nothing
(I didn't change anything in settings + Contextual Typography is installed too if that matters)

Thanks

UPDATE: since the new update all colored highlights are now single color:
image

@Hirashi3630 Hirashi3630 changed the title Highlights doesn't work Highlights don't work Oct 24, 2022
@dimib-tech
Copy link

Let me bump this post by posting a comment. Same here.

@jenpritchard
Copy link

Same here, a year later :(

antoKeinanen added a commit to antoKeinanen/obsidian-sanctum-reborn that referenced this issue Apr 14, 2024
antoKeinanen added a commit to antoKeinanen/obsidian-sanctum-reborn that referenced this issue Apr 14, 2024
@jfietz
Copy link

jfietz commented May 8, 2024

Anoter 6 monts, still an issue

@jdanielmourao
Copy link
Owner

Hi! Sorry for not getting back to you guys. Life got in the way, and I've been fully away from github for quite a while. This feature has been deprecated a while ago. It's my fault for not updating the documentation in so long, apologies.
I did manage to find an old css snippet through discord.

.markdown-rendered mark,
.cm-s-obsidian span.cm-highlight {
    font-weight: normal;
    color: black;
    background-color: transparent;
    background-image: linear-gradient(120deg,yellow,yellow));
    background-position: 0 100%;
    background-repeat: no-repeat;
    background-size: 100% 3px;
    transition: background 400ms ease;
}

.markdown-rendered mark:hover,
.cm-s-obsidian span.cm-highlight:hover {
    background-size: 100% 100%;
    color: black; /* change this if you need more contrast */
}

Though this has some of the CSS selectors updated, it will not work in the current version of obsidian.
I don't currently have an adequate setup to actively work on the theme, so I can't properly troubleshoot this for the time being. I'd recommend asking for help over on obsidian's discord. I'll try to get back to developing Sanctum asap though.
Again, sorry for the (really) long wait and unsatisfactory reply, and thank you for keeping an eye on Sanctum despite my absence. :)

@jfietz
Copy link

jfietz commented May 15, 2024

Do you intend to have a replacement feature for color-coding words / sections of a doc? If so, I'd be willing to take a deeper look in the next week(s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants