Multi monitor feature for video

[xaprier]

Added feature for issue #46

• Added right click context menu for items in iconview and for apply button.
  • Each monitor added to context menu to set which monitor to set and also "Set All" option.
• Added option for mute audio when there is maximized window(just mute, no stop)
• Used from screeninfo import get_monitors for getting monitor infos. Indexes same as videos from configs.
• Updated default config for setting multi monitor. JSON file kept like

  "data_source": [
     "/home/xaprier/Videos/Hidamari/ironman2.mp4",
     "/home/xaprier/Videos/Hidamari/ironman1.mp4"
  ],
  

[xaprier]

1 monitor and 3 monitor should be tested.

[jeffshee]

Hi @xaprier, thanks for the PR! 🤗
I'll do some code review and testing. It might take some time until the merge so please bear with me~

[xaprier]

I tested last implementation of monitors and it worked for me.

[xaprier]

I found a bug with "mute when maximized" option, but i cannot understand why and how to solve it for right now. Fixing if we apply wallpaper again but if starts automatically when launched its not working.

[xaprier]

Also if we use stream and webpage feature, it will broke with changing config.

[jeffshee]

Yes, you are right. There are more aspects that need to be reconsidered regarding the changes in the config, including:

• The migration from the previous config format to the current one, so that users don't need to reconfigure everything after the update.
• The behavior of audio playback: should all videos output sound when there are multiple sources configured?
• The behavior when the number of monitors changes:
  • Is the player spawned/terminated properly when a monitor is added/removed?
  • When a new monitor is added, which video source should it use?
• The impact/regression of this PR
• etc

I might push some commits directly to the PR branch if necessary 😃

[jeffshee]

The current implementation doesn't work when the monitor is added dynamically.
Perhaps the video sources in config should be a dict instead of an array, where the key is the name of the monitor (except the default, which is the video source used when a new (unconfigured) monitor is added):

{
  "default": "/path/to/video_set_as_default.mp4",
  "eDP1": "/path/to/video_set_as_edp1.mp4",
  "eDP2": "/path/to/video_set_as_edp2.mp4",
}

Just an idea in my head right now 😉

[xaprier]

• The behavior of audio playback should be the primary monitor if sound is not muted. The others will not play like now.
• The last applied video must be default i think, and if there will be added monitors, automatically it will set to default. We must watch the system to keep track of adding monitors.
• Config approach will be better with your saying. But we should consider if there will no monitor with key of config also.
  • Stream and web player should set default value i think, or we can add this feature to them also which is i would not recommend it.

[xaprier]

I will updating code with our discussion also. I'm just busy nowadays. But I will try to take a time