Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] build-nc-w64 is WIP #23

Open
jgabaut opened this issue Sep 13, 2023 · 3 comments
Open

[FEATURE] build-nc-w64 is WIP #23

jgabaut opened this issue Sep 13, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jgabaut
Copy link
Owner

jgabaut commented Sep 13, 2023

Describe the bug
With version 1.1.7, the mingw32 build is shipped as non-functional.
I will look into debugging the Windows version, but I don't know how hard the problem could be, as of now.

Update:

With version 1.1.8, a mockup gameloop, gameloop_Win(), was put in place for the _WIN32 build.
The issue is not to be closed yet, as while investigating I could not find a reason why just calling gameloop() would make the game crash.

To Reproduce
Steps to reproduce the behavior:

  1. Run the executable.
  2. Crash.

Expected behavior

Functional run at least up to the first ncurses interaction, which should fail the terminal capability checks on cmd.exe.

Desktop:

  • OS: Windows 10
  • Version: >= 1.1.6
@jgabaut jgabaut added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 13, 2023
@jgabaut jgabaut self-assigned this Sep 13, 2023
@jgabaut
Copy link
Owner Author

jgabaut commented Sep 14, 2023

Update:

With version 1.1.8, a mockup gameloop, gameloop_Win(), was put in place for the _WIN32 build.
The issue is not to be closed yet, as while investigating I could not find a reason why just calling gameloop() would make the game crash.

@jgabaut jgabaut changed the title x86_64-w64-mingw32 build is not working x86_64-w64-mingw32 build is WIP Sep 14, 2023
@jgabaut jgabaut removed the bug Something isn't working label Sep 16, 2023
@jgabaut jgabaut removed their assignment Nov 13, 2023
@jgabaut jgabaut removed the good first issue Good for newcomers label Nov 13, 2023
@jgabaut jgabaut changed the title x86_64-w64-mingw32 build is WIP [FEATURE] x86_64-w64-mingw32 build is WIP Nov 27, 2023
@jgabaut
Copy link
Owner Author

jgabaut commented Dec 25, 2023

Adding a note to remember that any print statements using ASCII colorcodes would be a problem under Windows.

While I think most of them were removed when dropping the legacy color system, it's something to check for since, for example, gameloop_Win() is using custom color-codes in the Rogue map display.

@jgabaut jgabaut self-assigned this Jan 5, 2024
@jgabaut jgabaut changed the title [FEATURE] x86_64-w64-mingw32 build is WIP [FEATURE] build-nc-w64 is WIP Feb 22, 2024
@jgabaut
Copy link
Owner Author

jgabaut commented Feb 22, 2024

Renaming this issue, since 1.4.3 (see PR) refactored the code concerning this into src/build-nc-w64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant