{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":488013154,"defaultBranch":"main","name":"sim-weather","ownerLogin":"jhubbard778","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-05-02T22:49:56.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/71090666?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1651531947.7373729","currentOid":""},"activityList":{"items":[{"before":"2ab67b0c538048bde87e49f4105cd90d6713767e","after":"f4ef3f9548902819a87186a1a81c1a9edb108b8a","ref":"refs/heads/main","pushedAt":"2024-04-22T05:05:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhubbard778","name":"Jakob Hubbard","path":"/jhubbard778","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71090666?s=80&v=4"},"commit":{"message":"Create LICENSE","shortMessageHtmlLink":"Create LICENSE"}},{"before":"f19590a9991259577d14c945b933888c9a7fd1ab","after":"2ab67b0c538048bde87e49f4105cd90d6713767e","ref":"refs/heads/main","pushedAt":"2023-10-16T11:46:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhubbard778","name":"Jakob Hubbard","path":"/jhubbard778","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71090666?s=80&v=4"},"commit":{"message":"mx.seed and bug fixes\n\n- Added new mx.seed variable functionality. It is a new variable in the 10-14-23 snapshot. I've allowed for backwards compatibility so the weather system will still work on older versions, it just won't be guaranteed to sync with other clients.\n\n- Fixed a bug where joining late in a session would crash the game trying to catch up lightning strikes.\n\n- Got rid of variables in file references for my track file cleaner program.","shortMessageHtmlLink":"mx.seed and bug fixes"}},{"before":"87a493430453edcd81b7d8cc60113e6707a9a7da","after":"f19590a9991259577d14c945b933888c9a7fd1ab","ref":"refs/heads/main","pushedAt":"2023-09-03T06:48:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhubbard778","name":"Jakob Hubbard","path":"/jhubbard778","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71090666?s=80&v=4"},"commit":{"message":"Bug Fixes & Organization\n\n- Fixed a small bug where skipping in a demo would sometimes cause the script to miss getting a lightning strike time if the time it got the lightning strike was very close to a weather change.\n\n- Reorganized a couple things such as:\n - Getting rid of addWeatherSounds() function in favor of adding the sounds directly in the object constructors.\n - Determining current thunder type based on a maxDelay property in the ThunderType object.\n - Renamed camera position and rotation variables to have camera in them to be more clear as to their purpose.\n - Calculate weather duration based on a range that the user can easily change rather than going and finding the function that calculates the duration.\n - Move Weather Types Array to the top before all of the object initialization.\n - Remove sounddirs and freqs properties from RainType and ThunderType objects since they weren't being used for anything other than adding the sounds.","shortMessageHtmlLink":"Bug Fixes & Organization"}},{"before":"60f72f04ce006ed2c309203171bff3efab5aa036","after":"87a493430453edcd81b7d8cc60113e6707a9a7da","ref":"refs/heads/main","pushedAt":"2023-08-24T06:00:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhubbard778","name":"Jakob Hubbard","path":"/jhubbard778","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71090666?s=80&v=4"},"commit":{"message":"Multiple Thunder Sound Position Updates\n\nBefore the current thunder sound would be the only thunder sound to be moved. Now in the case that two lightning strikes happen pretty close, it stores a timer for when to stop moving the sound.","shortMessageHtmlLink":"Multiple Thunder Sound Position Updates"}},{"before":"16f2eaabc80697651c7bae71bc5df600b8e93896","after":"60f72f04ce006ed2c309203171bff3efab5aa036","ref":"refs/heads/main","pushedAt":"2023-08-21T22:49:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhubbard778","name":"Jakob Hubbard","path":"/jhubbard778","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71090666?s=80&v=4"},"commit":{"message":"Remove Set Rain Loop Function & billboardIndexMap\n\n- Removed the set rain loop function and just set the rain loops inside of the add weather sounds function.\n\n- Removed the billboardIndexMap property from the rain type object and instead added an index property to the billboardArr object\n\n- Added @ symbol to folderName property in trackInfo object and renamed the property to folderDir\n\n- Changed a few comments for clarity and changed all RainType, ThunderType, and LightningTexture objects to variables instead of constants since we update some properties later.","shortMessageHtmlLink":"Remove Set Rain Loop Function & billboardIndexMap"}},{"before":"767f18a8158ddc0fa76ef313c8cfb8bb30a201f0","after":"16f2eaabc80697651c7bae71bc5df600b8e93896","ref":"refs/heads/main","pushedAt":"2023-08-20T21:54:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhubbard778","name":"Jakob Hubbard","path":"/jhubbard778","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71090666?s=80&v=4"},"commit":{"message":"Reoganization\n\nReorganized a lot of the code to put any variable changes the user wants to make to the script at the top.\n\n- Changed clunky thunder and rain plain objects into ES5 class-like objects.\n\n- Changed Lightning Textures to hold an array of objects that hold each necessary property of each texture.\n\n- Move each type of rain/lightning billboards to their grid like pattern on start (this has absolutely zero effect on the script other than looking cool in the editor on load)","shortMessageHtmlLink":"Reoganization"}},{"before":"ba3e2ce115d3c5b16ca03c6e2d15c6dffd55b41b","after":"767f18a8158ddc0fa76ef313c8cfb8bb30a201f0","ref":"refs/heads/main","pushedAt":"2023-08-20T01:01:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhubbard778","name":"Jakob Hubbard","path":"/jhubbard778","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71090666?s=80&v=4"},"commit":{"message":"Rain Billboard Rework\n\nReworked the rain billboard system to not have the need for any billboards in the billboards file. Instead it tries to find rain billboards and if there's not enough it will keep adding. If there's excess it will hide the excess billboards.\n\n- Each rain type now posseses 4 new properties:\n\n- size: holds the size for each rain billboard\n- aspect: holds the aspect ratio for each rain billboard\n- maxBillboardHeight: the maximum height of the billboard in feet before the it starts following the camera\n- billboardIndexMap: an array that maps a billboardArr index to a rain billboard index.\n\nWith these new features and properties the indexStart property of the rain objects became obsolete.","shortMessageHtmlLink":"Rain Billboard Rework"}},{"before":"145276501d970ccc2759c587dd38cf2d85000b7e","after":"ba3e2ce115d3c5b16ca03c6e2d15c6dffd55b41b","ref":"refs/heads/main","pushedAt":"2023-08-19T09:00:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhubbard778","name":"Jakob Hubbard","path":"/jhubbard778","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71090666?s=80&v=4"},"commit":{"message":"Small Fix to Lightning Coords & Size\n\nI did not realize that the toFixed() function returned a string and this caused me issues when trying to move and size billboards. I worked around by parsing to float but I had no idea why the values were strings at the time.\n\nValues are implicitly reconverted back to number types during calculation with a plus sign proceeding the returned string value from .toFixed().","shortMessageHtmlLink":"Small Fix to Lightning Coords & Size"}},{"before":"7f03d99e171801f5852c140e2ea9dec8308f3b09","after":"145276501d970ccc2759c587dd38cf2d85000b7e","ref":"refs/heads/main","pushedAt":"2023-08-19T08:26:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhubbard778","name":"Jakob Hubbard","path":"/jhubbard778","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71090666?s=80&v=4"},"commit":{"message":"Lightning Animations\n\nAdded Lightning Animations.\n\n- Fixed issue with y values not being properly calculated for a lightning strike coordinate.\n\n- Added condition in mulberry32Seed where if the min and the max are equal just return the minimum value.","shortMessageHtmlLink":"Lightning Animations"}},{"before":"cc66bc9d281fd0a9825f698d9cd24e0e1e652b95","after":"7f03d99e171801f5852c140e2ea9dec8308f3b09","ref":"refs/heads/main","pushedAt":"2023-08-18T07:44:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhubbard778","name":"Jakob Hubbard","path":"/jhubbard778","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71090666?s=80&v=4"},"commit":{"message":"Bug fixes and try catches\n\n- Fixed bug where loading in late into a server would cause to get stuck in an infinite loop because the weather wouldn't change from -1 to 0 and so forth.\n\n- Fixed bug where if you're converting an index to a weather type the weather type returned could be undefined because if you haven't updated the weather iteration through indices yet it is possible that it could return an index out of bounds.\n\n- Changed mulberry32Seed function to be inclusive of the max value.\n\n- Added try catches in .includes checks to try and find and lingering bugs that may pop up unexpectedly.","shortMessageHtmlLink":"Bug fixes and try catches"}},{"before":"082e7060dda8add3f61affa9f1a1be2833b8031c","after":"cc66bc9d281fd0a9825f698d9cd24e0e1e652b95","ref":"refs/heads/main","pushedAt":"2023-08-18T02:04:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhubbard778","name":"Jakob Hubbard","path":"/jhubbard778","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71090666?s=80&v=4"},"commit":{"message":"Fix Billboard Height and Load in Bug\n\nFixed a billboard height bug where no rain spots were constantly resetting between the billboard height and zero. Also fixed where it wouldn't set billboard to camera height if the billboard was in a no rain spot and was above the billboard height specified.\n\nFixed load in bug where current weather type would be undefined if you were tabbed out before the session started.","shortMessageHtmlLink":"Fix Billboard Height and Load in Bug"}},{"before":"7a9deba030c644e13b22fabff79bfbee6eaf4271","after":"082e7060dda8add3f61affa9f1a1be2833b8031c","ref":"refs/heads/main","pushedAt":"2023-08-17T10:28:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhubbard778","name":"Jakob Hubbard","path":"/jhubbard778","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71090666?s=80&v=4"},"commit":{"message":"Major Bug Fixes & Small Additions\n\nMajor bug fixes include:\n\n- Catching up lightning strikes and making sure they're synced with clients who were not tabbed out.\n\n- Weather not syncing properly going backwards in a demo (forgot to add the gatedroptime to the time weather started vs seconds check)\n\n- Weather time left not accurately being calculated (forgot to add gate drop time to timeWeatherStarted variable when calculating the time left)\n\nChanges:\n\n- Changed getWeatherType() to include the option to return the weather index and also the option to change the current weather. If neither of those are defined it will do the default action of returning the current weather type and switching if necessary.\n\n- Iterations through weather indices list now zero index based instead of 1 index based.\n\n- Changed getLightningStrike() function to have the option of passing in an intervals array as it was necessary to catch up the lightning strikes.\n\n- Changed doesWeatherHaveThunder() function to pass in a weather type and also allow the option to pass in a boolean that will be checked if you want to remove a pending lightning strike.\n\nAdditions:\n- Started work on lightning texture code for choosing a lightning texture based on the lightning strike time.\n\n- Added small function that converts a weather index into a weather type string.","shortMessageHtmlLink":"Major Bug Fixes & Small Additions"}},{"before":"48eb1dada2ad15c9248764092c82dbf831e78375","after":"7a9deba030c644e13b22fabff79bfbee6eaf4271","ref":"refs/heads/main","pushedAt":"2023-08-09T06:46:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhubbard778","name":"Jakob Hubbard","path":"/jhubbard778","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71090666?s=80&v=4"},"commit":{"message":"Billboard in Front of Smited Player\n\nAdded billboard that places itself in front of the camera of the smited player, used a temporary billboard in place of a prompt later.\n\nAlso added smiting check to tabbing out or joining late lightning strikes.","shortMessageHtmlLink":"Billboard in Front of Smited Player"}},{"before":"3f397b4373f36667c03d90ebe834093a2f41b274","after":"48eb1dada2ad15c9248764092c82dbf831e78375","ref":"refs/heads/main","pushedAt":"2023-08-07T12:42:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jhubbard778","name":"Jakob Hubbard","path":"/jhubbard778","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71090666?s=80&v=4"},"commit":{"message":"Complete Rework of Rain/Thunder\n\nCompletely reworked the way rain/thunder is handled. So far I've changed the rain function to no longer check if the rain type is light, medium, or heavy every time it's needed. It will instead check it only once and set a current rain type and that current rain type will hold an object with all the necessary sounds, billboards, and volumes. That current rain type is used for all the work instead of all the extra checks.\n\nThunder and lightning now works on the same type of system that the weather cycles work, it stores each lightning strike in an array and goes through different cycles. It also now bases all the next lightning strike times off of a shared seed value for all clients so it won't matter if someone's second counter is slightly different, everyone will see them at the same time. So the thunder & lightning system now works so that its both seeded and can be ran back in demos and be played at the exact same time every time.\n\nI've been stuck trying to get the thunder/lightning system to account for tabbed out players or players that join late because the current weather could be completely different from the weather they tabbed out or joined during. I will have to try to find a work around.\n\nI also added a no rain spots a while ago where if the camera is in a spot where rain should be hitting an object it will move the billboard to the specified billboard height in that area. It uses vertices to draw a polygon and checks if the camera is in that polygon.\n\nI also added a smite system a long time ago as a joke, it will smite people with specified names in the list and then go down the list and start picking off riders 1 by 1 crashing their game as if they died.","shortMessageHtmlLink":"Complete Rework of Rain/Thunder"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAENp7lRQA","startCursor":null,"endCursor":null}},"title":"Activity ยท jhubbard778/sim-weather"}