Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot resolve $git_dirty inside of $GIT_DIR #6

Open
eacousineau opened this issue Mar 22, 2013 · 3 comments
Open

Cannot resolve $git_dirty inside of $GIT_DIR #6

eacousineau opened this issue Mar 22, 2013 · 3 comments

Comments

@eacousineau
Copy link
Contributor

find_git_dir() does not play nicely inside of $GIT_DIR, hence the error message checking.
A possible solution would be to resolve the proper work tree directory. Not sure how to do that with the plumbing / porcelain stuff (realized I should have said "plumbing" in that first commit haha). Trying out the "root" alias trick did not seem to work either.

@jimeh
Copy link
Owner

jimeh commented Apr 25, 2013

When you say $GIT_DIR, do you mean the .git folder inside of a working directory? If not, sorry for my stupidity. If yes, then I'm not sure it's a huge deal, git status doesn't work inside of it either :)

@eacousineau
Copy link
Contributor Author

Yeah, that was what I meant, so no need for apologies haha. I agree that it isn't a huge deal (now that it seems hard to implement :P).

@jimeh
Copy link
Owner

jimeh commented Apr 28, 2013

Well, only thing I can think of is checking if the output from pwd for example contains /.git, and then attempt run git status against the parent directory of the .git directory. I might give it a shot just for fun, and if it doesn't slow down the find_git_dirty function in any noticeable way I'll push it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants