Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: commit-reveal module #1526

Open
seanmc9 opened this issue Apr 9, 2024 · 0 comments
Open

feat: commit-reveal module #1526

seanmc9 opened this issue Apr 9, 2024 · 0 comments
Labels

Comments

@seanmc9
Copy link
Member

seanmc9 commented Apr 9, 2024

have draft in #1529

  • module has commit and reveal periods, both within the voting period of the underlying contest
  • commit-reveal contests must have a 0 voting merkle root - we verify that it's the official commit-reveal module doing the voting in the vote transaction
  • at reveal, they sign in w Ethereum, we give them the info, and they send in this info and we also check on smart contract level that the voter is the one revealing so they ultimately decide if their committed votes get counted.
  • one commit with all of your votes - for UX so users only have to sign one message to reveal, but also has added benefit of making it super straightforwards to update a commit if needed, whereas multiple commits (like a commit per proposal voted on would not really be updatable)
    • so the data structure that will get committed is keccack(VoteData[], salt) where VoteData is uint256 proposalId, uint8 support, uint256 numVotes (from castVoteWithoutProof())
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

1 participant