Add support for left/right arrows to move terminal line cursor #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmbake
reviewed
May 2, 2023
jonmbake
reviewed
May 2, 2023
jonmbake
reviewed
May 2, 2023
jonmbake
approved these changes
May 2, 2023
jonmbake
reviewed
May 3, 2023
| <div ref={ scrollIntoViewRef }></div> | ||
| </div> | ||
| <input className="terminal-hidden-input" placeholder="Terminal Hidden Input" value={ currentLineInput } autoFocus={ onInput != null } onChange={ updateCurrentLineInput } onKeyDown={ handleInputKeyDown }/> | ||
| <input id="hidden" className="terminal-hidden-input" placeholder="Terminal Hidden Input" value={ currentLineInput } autoFocus={ onInput != null } onChange={ updateCurrentLineInput } onKeyDown={ handleInputKeyDown }/> |
There was a problem hiding this comment.
I'll check this, but there have been a bug introduced here when multiple terminals are rendered by using an id attr. @jerwolff I think we may want to use a ref to look this el up, instead of using id.
There was a problem hiding this comment.
Oh yeah that's a good point, I should be using a ref. I can work on that.
There was a problem hiding this comment.
You may be able to avoid using both a ref and id, and instead use event.currentTarget in #handleInputKeyDown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in relation to issue #36