Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: custom icon for Off-Canvas menu #202

Open
sergeytolkachyov opened this issue Nov 7, 2020 · 5 comments
Open

Feature request: custom icon for Off-Canvas menu #202

sergeytolkachyov opened this issue Nov 7, 2020 · 5 comments

Comments

@sergeytolkachyov
Copy link

It would be nice to have an opportunity to change a off-canvas menu icon.

@chetanmadaan
Copy link
Member

chetanmadaan commented Nov 8, 2020

We added the possibility to change the color of the icon recently, but I don't think we have this anywhere on the road map.

@semnaveen input?

@semnaveen
Copy link
Member

@chetanmadaan we don't have this feature in our road map yet.

I guess we can give this feature.

@hiteshaggarwal
Copy link
Contributor

Hi @sergeytolkachyov, Thanks for the suggestion, In upcoming version of Astroid, We added offcanvas's trigger button and close button layout, So now they can easily overridable. You can override by copying files from JOOMLA_ROOT/libraries/astroid/framework/frontend/offcanvas to YOUR_TEMPLATE/html/frontend/offcanvas

Thanks

@Nishtha003
Copy link
Contributor

Added this in the new Astroid 2.5 version, please update and test this and let us know the feedback!

Thanks,
Nishtha

@sergeytolkachyov
Copy link
Author

sergeytolkachyov commented Feb 18, 2021

Added this in the new Astroid 2.5 version, please update and test this and let us know the feedback!

Thanks,
Nishtha

Thanks, but I can't use it on production untill #201 will be solved. I downgrade Astroid Framework to 2.3.0. I don't want to hack Astroid manually and still waiting a bugfix #201.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants