Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spellcheck runs in code cells but not markdown cells #143

Closed
psychemedia opened this issue May 16, 2024 · 4 comments
Closed

Spellcheck runs in code cells but not markdown cells #143

psychemedia opened this issue May 16, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@psychemedia
Copy link

psychemedia commented May 16, 2024

In JupyterLab 4.1.8, the spellchecker is (correctly) highlighting spelling errors in code cells, but not identifying any spelling errors in markdown cells.

image

In the devtools console, I see the following warnings as I type, though it's not clear to me what might be raising them or whether that issue relates to the spellchecker's incorrect behaviour?

highlights.ts:343 Could not get highlights: TypeError: Cannot read properties of undefined (reading 'isReady')
    at Qt.requestHighlights (highlights.ts:217:20)
    at a.factory [as _factory] (jlab_core.b91074b1e57242ddcd31.js?v=b91074b1e57242ddcd31:1:1758915)
    at a._execute (jlab_core.b91074b1e57242ddcd31.js?v=b91074b1e57242ddcd31:1:1757383)
    at o (jlab_core.b91074b1e57242ddcd31.js?v=b91074b1e57242ddcd31:1:1756803)

@psychemedia psychemedia added the bug Something isn't working label May 16, 2024
@krassowski
Copy link
Collaborator

For me spellchecking in markdown works great. This error you show comes from jupyterlab-lsp, not from spellchecker; it is possible that that error could be breaking the editor logic and thus the spellchecker.

https://github.com/jupyter-lsp/jupyterlab-lsp/blob/b159ae2736b26463d8cc8f0ef78f4b2ce9913370/packages/jupyterlab-lsp/src/features/highlights.ts#L208

Can you open an issue on https://github.com/jupyter-lsp/jupyterlab-lsp showing how to reproduce this error (and listing versions of the extension, and language servers installed).

@psychemedia
Copy link
Author

@krassowski ok, thanks (though I would expect it to be more likley that any jupyterlab-lsp error would cause issues with code cells rather than markdown cells?)

@krassowski
Copy link
Collaborator

In Lab 4 LSP is also supported in Markdown cells.

@psychemedia
Copy link
Author

It seems there's a conflict with jupysql-plugin that breaks the spell checker in markdown cells (issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants