refactor(router): changed payment method token TTL to api contract based config from const value

[sahkal]

Type of Change

• Bugfix
• New feature

Description

Currently the payment method token TLL calculation was done based on const::TOKEN_TTL - payment_intent.created_at

where TOKEN_TTL was 15mins, but as we have a new contract called session_expiry we can make our payment live for longer time constraint than just 15mins,

due to this, the value const::TOKEN_TTL - payment_intent.created_at might go negative if the payment is done after 15mins. Which causes negative value at redis.

To solve, This problem we have used intent_fulfillment_time in business profile which is set by the merchant.

max value of intent_fulfillment_time can be 30mins and min can be 1min

How did you test it?

[Scenario 1] : Create a new business account
Create a merchant -> Create business profile with intent_fulfillment_time as 60s -> do payment connector step -> Create api key ->

Business Create

curl --location 'http://localhost:8080/account/merchant_1719312571/business_profile' \
--header 'Content-Type: application/json' \
--header 'api-key: test_admin' \
--data '{
  "profile_name": "fooddqw",
  "intent_fulfillment_time":60
}'

Do payment create with payment link

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_Ccb0N9Nd43rBhCANbXit86h820vVpcXkexpgbAw5efxjwiUC6UYiTeOtW446kkpa' \
--data-raw '
{
    "amount": 250,
    "currency": "USD",
    "payment_link":true,
    "profile_id": "pro_D1CA5xM3jTuo1r0XHp9e",
    "amount_to_capture": 250,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "customer_id": "StripeCustomer123",
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "Please Pay for your XYZ",
    "authentication_type": "no_three_ds",
    "return_url": "https://google.com",
    "setup_future_usage": "off_session",
    "browser_info": {
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "language": "nl-NL",
        "color_depth": 24,
        "screen_height": 723,
        "screen_width": 1536,
        "time_zone": 0,
        "java_enabled": true,
        "java_script_enabled": true,
        "ip_address": "127.0.0.1"
    },
    "routing": {
        "type": "single",
        "data": "nmi"
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    },
    "payment_link_config":{
        "enabled_saved_payment_method":true
      }}
    
'

Do the payment after 60 seconds it should fail, with log as

[Scenario 2] : Update business account

Now Do update business profile

curl --location 'http://localhost:8080/account/merchant_1719312571/business_profile/pro_D1CA5xM3jTuo1r0XHp9e' \
--header 'Content-Type: application/json' \
--header 'api-key: test_admin' \
--data '{
  "intent_fulfillment_time":900
}'

Now do payment link create

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_Ccb0N9Nd43rBhCANbXit86h820vVpcXkexpgbAw5efxjwiUC6UYiTeOtW446kkpa' \
--data-raw '
{
    "amount": 250,
    "currency": "USD",
    "payment_link":true,
    "profile_id": "pro_D1CA5xM3jTuo1r0XHp9e",
    "amount_to_capture": 250,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "customer_id": "StripeCustomer123",
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "Please Pay for your XYZ",
    "authentication_type": "no_three_ds",
    "return_url": "https://google.com",
    "setup_future_usage": "off_session",
    "browser_info": {
        "user_agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36",
        "accept_header": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8",
        "language": "nl-NL",
        "color_depth": 24,
        "screen_height": 723,
        "screen_width": 1536,
        "time_zone": 0,
        "java_enabled": true,
        "java_script_enabled": true,
        "ip_address": "127.0.0.1"
    },
    "routing": {
        "type": "single",
        "data": "nmi"
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    },
    "payment_link_config":{
        "enabled_saved_payment_method":true
      }}
'

Now doPay now after 3mins, it should pass

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code
• I added unit tests for my changes where possible

[jarnura]

LGTM

[Narayanbhat166]

why is this value hard coded?