Plotting functions with more general arrays #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustaphe
commented
Sep 11, 2022
| @@ -82,19 +86,19 @@ end | |||
| end | |||
|
|
|||
| # Recipes for functions | |||
| @recipe function f(f::Function, x::T) where T <: AVec{<:Union{Missing,<:Quantity}} | |||
| @recipe function f(f::Function, x::T) where T <: AArr{<:UMQ} | |||
There was a problem hiding this comment.
Meaningful change
gustaphe
commented
Sep 11, 2022
| x, f.(x) | ||
| end | ||
| @recipe function f(x::T, f::Function) where T <: AVec{<:Union{Missing,<:Quantity}} | ||
| @recipe function f(x::T, f::Function) where T <: AArr{<:UMQ} |
There was a problem hiding this comment.
Meaningful change
gustaphe
commented
Sep 11, 2022
Comment on lines
+110
to
+112
| @recipe function f(u::Units, f::Function) | ||
| return f, u | ||
| end |
There was a problem hiding this comment.
A mirror of f(f, u)
gustaphe
commented
Sep 11, 2022
Comment on lines
+113
to
+128
| #========================================================================= | ||
| If x is an array of arrays of quantities, consider those different series. | ||
| No need to dive deeper than this, a plot of arrays of arrays of arrays is | ||
| not implemented in Plots. | ||
| =========================================================================# | ||
| @recipe function f(f::Function, x::AArrArrQ) | ||
| for s in x | ||
| @series begin | ||
| xunit := unit(first(first(x))) | ||
| f, s | ||
| end | ||
| end | ||
| end | ||
| @recipe function f(x::AArrArrQ, f::Function) | ||
| return f, x | ||
| end |
Codecov ReportBase: 88.80% // Head: 87.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
==========================================
- Coverage 88.80% 87.40% -1.40%
==========================================
Files 1 1
Lines 125 135 +10
==========================================
+ Hits 111 118 +7
- Misses 14 17 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #71.
Accept unitful AbstractArrays and Vectors of unitful Vectors as the x axis to functions, leading to multiple series.
(Also more consistently abbreviate array types to save text width and increase legibility, and create a
plot(u, f)recipe to go with theplot(f, u)recipe)