Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Help needed] Support using pre-compiled ncnn library #258

Open
csukuangfj opened this issue Aug 29, 2023 · 0 comments
Open

[Help needed] Support using pre-compiled ncnn library #258

csukuangfj opened this issue Aug 29, 2023 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@csukuangfj
Copy link
Collaborator

csukuangfj commented Aug 29, 2023

Currently, we use a fork of ncnn

set(ncnn_URL "https://github.com/csukuangfj/ncnn/archive/refs/tags/sherpa-1.1.tar.gz")

But actually, sherpa-ncnn supports using the master of
https://github.com/tencent/ncnn/

We need to change

include(ncnn)

to something like below

find_package(ncnn)

if(NOT ncnn_FOUND)
  include(ncnn)
endif()

We also need to add tests to cover the above change.


Please see
https://github.com/Tencent/ncnn/wiki/use-ncnn-with-own-project
for further information.

@csukuangfj csukuangfj added the help wanted Extra attention is needed label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant