From 029f2973e895dd2a61ec59fd5694dc9036caa1df Mon Sep 17 00:00:00 2001 From: kabir-afk Date: Mon, 17 Jun 2024 14:26:12 +0530 Subject: [PATCH 1/3] refactor : i18n now working in FF ormalizeMessage unction was interfering with the message , so moved it before function was called --- background-script.js | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/background-script.js b/background-script.js index e74bad2..4722a5c 100644 --- a/background-script.js +++ b/background-script.js @@ -413,6 +413,11 @@ else if (message.command === "storeParam") { const [name,value] = message.argument; storeParam(name,value); return; +} +else if (message.command === 'bananai18n') { + let [msg,placeholderValue] = message.arg; + const i18nMessage = banana.i18n(msg,...placeholderValue); + return i18nMessage; } message = normalizeMessage(message); @@ -420,14 +425,7 @@ else if (message.command === "storeParam") { if ( message.command === 'signit.getfiles' ) { console.log('bg>signit.getfiles') return records[ message.text ] || records[ message.text.toLowerCase() ] || []; - } - // When message 'signit.i18nCode' is heard, returns banada object - else if (message.command === 'bananai18n') { - let [msg,placeholderValue] = message.arg; - const i18nMessage = banana.i18n(msg,placeholderValue); - return i18nMessage; - } - + } // Start modal // When right click's menu "Lingua Libre SignIt" clicked, send message 'signit.sign' to the content script => opens Signit modal else if ( message.command === 'signit.hinticon' ) { From 8725e22020fa5c8fe61a0ba4a7fa686bba03aeee Mon Sep 17 00:00:00 2001 From: kabir-afk Date: Mon, 17 Jun 2024 16:54:54 +0530 Subject: [PATCH 2/3] update : removed sourceMap and bananaInStore from local storage, no longer needed --- background-script.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/background-script.js b/background-script.js index 4722a5c..5375542 100644 --- a/background-script.js +++ b/background-script.js @@ -164,8 +164,6 @@ async function loadI18nLocalization( uiLanguageQid ) { // Declare localisation banana.setLocale(locale); // Change to new locale - storeParam('bananaInStore',banana) - storeParam("sourceMap", Array.from(banana.messageStore.sourceMap)); state = 'ready'; From c46538c1f016ea2720f81de4d1d8156e7a7027e2 Mon Sep 17 00:00:00 2001 From: kabir-afk Date: Mon, 17 Jun 2024 17:02:08 +0530 Subject: [PATCH 3/3] update : changed variable names --- SignItCoreContent.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/SignItCoreContent.js b/SignItCoreContent.js index 5e08733..a62bda7 100644 --- a/SignItCoreContent.js +++ b/SignItCoreContent.js @@ -68,19 +68,19 @@ var SignItCoreContent = function () { banana.i18n("si-panel-definitions-wikt-pointer"), banana.i18n("si-panel-definitions-empty") // May need a different key for error message ]); - const [videosPanelNoVideoTitle, videosPanelNoVideoEmpty, definitionsPanelTitle, contributeButtonLabel, wiktIso, wiktPointer, definitionsEmpty] = translations; + const [panelVideosTitle, panelVideosEmpty, panelDefinitionsTitle, panelVideosContributeLabel, wiktIso, wiktPointer, panelDefinitionsEmpty] = translations; - this.$container.find(".signit-panel-videos .signit-novideo h2").text(videosPanelNoVideoTitle); - this.$container.find(".signit-panel-videos .signit-novideo p").html(videosPanelNoVideoEmpty); // -- needs additional css - this.$container.find(".signit-panel-definitions .signit-definitions h2").text(definitionsPanelTitle); - this.contributeButton.$label.text(contributeButtonLabel); + this.$container.find(".signit-panel-videos .signit-novideo h2").text(panelVideosTitle); + this.$container.find(".signit-panel-videos .signit-novideo p").html(panelVideosEmpty); // -- needs additional css + this.$container.find(".signit-panel-definitions .signit-definitions h2").text(panelDefinitionsTitle); + this.contributeButton.$label.text(panelVideosContributeLabel); const definitionsSourceLink = `https://${wiktIso}.wiktionary.org`; this.$container .find(".signit-definitions-source a") .attr("href", definitionsSourceLink) .text(wiktPointer); - this.$container.find(".signit-panel-definitions .signit-error").text(definitionsEmpty); + this.$container.find(".signit-panel-definitions .signit-error").text(panelDefinitionsEmpty); } catch (error) { console.error("Error fetching translations:", error);