Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overwrite=False in EmbeddingsWriter doesn't work #557

Closed
nkaenzig opened this issue Jul 4, 2024 · 0 comments · Fixed by #558
Closed

overwrite=False in EmbeddingsWriter doesn't work #557

nkaenzig opened this issue Jul 4, 2024 · 0 comments · Fixed by #558
Assignees
@nkaenzig

Comments

@nkaenzig
Copy link
Collaborator

nkaenzig commented Jul 4, 2024

Setting overwrite=False should raise an Exception if the embeddings already exist in the specified output directory. Currently it just proceeds and overwrites the files.
@nkaenzig nkaenzig added the bug Something isn't working label Jul 4, 2024
@nkaenzig nkaenzig self-assigned this Jul 4, 2024
@nkaenzig nkaenzig mentioned this issue Jul 4, 2024
Merged
@nkaenzig nkaenzig linked a pull request Jul 4, 2024 that will close this issue
Change overwrite default value to True in EmbeddingWriter #558
Merged
@nkaenzig nkaenzig removed the bug Something isn't working label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkaenzig nkaenzig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change overwrite default value to True in EmbeddingWriter kaiko-ai/eva
1 participant
@nkaenzig