-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: distinguish highlight for function symbol and normal var symbol #1386
Conversation
4ecfd21
to
063b1ca
Compare
Pull Request Test Coverage Report for Build 9352165444Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
8ca81ac
to
5e01c58
Compare
Can you please review the changes, @Peefy |
|
no, you need to update the lambda expr to a function symbol first, then update call expr, e.g.,
you need to update the symbol kcl/kclvm/sema/src/namer/node.rs Line 99 in c07925f
and walk_identifier_expr() in advanced_resolver kcl/kclvm/sema/src/advanced_resolver/node.rs Line 1074 in c07925f
|
I don't think we should call the corresponding syntax nodes such as |
PR conflicted. |
Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> add function symbol kind to lsp Signed-off-by: shruti2522 <[email protected]> update function symbol def Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> fix ci Signed-off-by: shruti2522 <[email protected]> fix ci Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> add tests to sema_token Signed-off-by: shruti2522 <[email protected]> add get_function_symbol Signed-off-by: shruti2522 <[email protected]> highlight for func call Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> modify walk_call_expr Signed-off-by: shruti2522 <[email protected]> update namer for func_name Signed-off-by: shruti2522 <[email protected]> feat: distinguish highlight for func symbol and normal var symbol Signed-off-by: shruti2522 <[email protected]> update alloc_function_symbol Signed-off-by: shruti2522 <[email protected]> function symbol for builtin functions Signed-off-by: shruti2522 <[email protected]> update function symbol def Signed-off-by: shruti2522 <[email protected]> delete test.log Signed-off-by: shruti2522 <[email protected]> remove func symbol from walk_call_expr Signed-off-by: shruti2522 <[email protected]> update walk_call_expr for namer Signed-off-by: shruti2522 <[email protected]> update sema test Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> add function symbol kind in global state Signed-off-by: shruti2522 <[email protected]> update hover to handle func symbolkind Signed-off-by: shruti2522 <[email protected]> add condition for symbolkind in hover Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> remove print statements Signed-off-by: shruti2522 <[email protected]> update loader snapshots Signed-off-by: shruti2522 <[email protected]> fix advanced resolver Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> update assign stmt for lambda expr Signed-off-by: shruti2522 <[email protected]> update resolve_names for identifier_expr Signed-off-by: shruti2522 <[email protected]> update semantic tokens with function type Signed-off-by: shruti2522 <[email protected]> feat: api list_variables supports get variables from multi-files (kcl-lang#1389) * feat: api list_variables supports get variables from multi-files Signed-off-by: zongz <[email protected]> * fix: fix CR comments Signed-off-by: zongz <[email protected]> * fix: fix test cases Signed-off-by: zongz <[email protected]> --------- Signed-off-by: zongz <[email protected]> feat: advance resolver incremental compile (kcl-lang#1209) feat: advanced resolver incremental compile. 1. Namer and Advanced Resolver support incremental compilation, clear cache by pkg and only update new pkg 2. Add gs cache in lsp state 3. Namer and Advanced Resolver modify gs in place(&mut) to reduce clone Signed-off-by: he1pa <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> resolve conflicts Signed-off-by: shruti2522 <[email protected]> resolve conflicts Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]> resolve conflicts Signed-off-by: shruti2522 <[email protected]> remove duplicate code Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> remove repititions Signed-off-by: shruti2522 <[email protected]> fmt check Signed-off-by: shruti2522 <[email protected]> feat: added FunctionSymbol Signed-off-by: shruti2522 <[email protected]>
Signed-off-by: shruti2522 <[email protected]> remove unwanted changes in global_state Signed-off-by: shruti2522 <[email protected]>
Signed-off-by: shruti2522 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
fix [Enhancement] Distinguish the highlight of function symbol and normal var symbol #1378
2. What is the scope of this PR (e.g. component or file name):
kclvm/sema/src/core/symbol.rs
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: