Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide versioning for our FAQ #935

Closed
Tracked by #228
tomkerkhove opened this issue Sep 14, 2022 · 7 comments · Fixed by #1416
Closed
Tracked by #228

Provide versioning for our FAQ #935

tomkerkhove opened this issue Sep 14, 2022 · 7 comments · Fixed by #1416
Assignees
Labels
cant-touch-this All issues that should not be automatically closed by our stale bot

Comments

@tomkerkhove
Copy link
Member

Provide versioning for our FAQ, given the FAQ data is specific per version (ie supported Kubernetes version)

https://keda.sh/docs/2.9/faq/

@tomkerkhove tomkerkhove added the documentation Improvements or additions to documentation label Sep 14, 2022
@stale
Copy link

stale bot commented Nov 14, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Nov 14, 2022
@tomkerkhove tomkerkhove removed the stale All issues that are marked as stale due to inactivity label Nov 14, 2022
@stale
Copy link

stale bot commented Jan 13, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jan 13, 2023
@tomkerkhove tomkerkhove added cant-touch-this All issues that should not be automatically closed by our stale bot and removed documentation Improvements or additions to documentation labels Jan 16, 2023
@stale
Copy link

stale bot commented Jan 23, 2023

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Jan 23, 2023
@tomkerkhove tomkerkhove removed the stale All issues that are marked as stale due to inactivity label Jan 23, 2023
@tomkerkhove tomkerkhove reopened this Jan 23, 2023
@thisisobate
Copy link
Contributor

thisisobate commented Jun 25, 2024

@tomkerkhove I think this is already completed. Can we close this one?

@tomkerkhove
Copy link
Member Author

Not really, there is an FAQ file per version but it all pulls from https://github.com/kedacore/keda-docs/blob/main/data/faq20.toml which is shared across all versions

@thisisobate
Copy link
Contributor

Then I guess we just have to update 2.14 and above to not pull from faq20.toml.

@thisisobate
Copy link
Contributor

Will have to keep this one pending until #1389 gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cant-touch-this All issues that should not be automatically closed by our stale bot
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants